I suspect it was far more valuable in pre-Internet non-population-dense America, where it was one of the few effective ways to connect with other smart people. It is extremely obsolete now. But "they" (whoever "they" is in practice) publish some nifty puzzle books.
At the time I'm writing this, yours may be the only answer in this thread that doesn't try to signal moral superiority to Mensa members by piously insulting them. (There are a couple of other comments that I would consider borderline -- not overtly insulting, but carefully suffused with cynicism.)
It is a nice way to meet other people that are (somewhat) smart (in a new city, or beyond ones social circle). What is especially good about it is the relative diversity of backgrounds that members are from (and different ages).
However the atmosphere at Mensa varies much from area to area (sometimes a bit pretentious, but in other areas very low key, pleasant and surprisingly open). And one should not take it too seriously.